Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new class structure for a values #201

Merged
merged 4 commits into from
Jan 29, 2025
Merged

feat: new class structure for a values #201

merged 4 commits into from
Jan 29, 2025

Conversation

gottschali
Copy link
Collaborator

@gottschali gottschali commented Jan 23, 2025

This PR reproduces the structure of the b-value estimators suggested by @schmidni for a-values.

  • Structure: analysis/avalue with estimators and test
  • AValueEstimator as abstract class
    • ClassicAValueEstimator
    • APositiveAValueEstimator
  • add estimate_a function to __init__.py
  • AMorePositiveAValueEstimator
  • Better tests (it would be good if someone with more domain knowledge did this)
  • sanity checks. Are there different ones for a values? Probably include the binning test.

Added a common method _reference_scaling since both estimators shared code for scaling by m_ref and scaling_factor.

calculate is overridden for APositive to get the correct docstring.

To avoid too many merge conflicts, we kept the original implementation for now.
But later if should be removed.

@schmidni
Copy link
Member

@gottschali thanks for starting. I'm taking over from here as I have to do a few more changes too :)

@schmidni schmidni marked this pull request as ready for review January 29, 2025 14:35
@schmidni schmidni merged commit 3130b2d into main Jan 29, 2025
2 checks passed
@schmidni schmidni deleted the refactor/aclass2 branch January 29, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants