feat: new class structure for a values #201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproduces the structure of the b-value estimators suggested by @schmidni for a-values.
analysis/avalue
with estimators and testAValueEstimator
as abstract classClassicAValueEstimator
APositiveAValueEstimator
estimate_a
function to__init__.py
AMorePositiveAValueEstimator
Added a common method
_reference_scaling
since both estimators shared code for scaling bym_ref
andscaling_factor
.calculate
is overridden for APositive to get the correct docstring.To avoid too many merge conflicts, we kept the original implementation for now.
But later if should be removed.