Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows arm64 mainline builds fail since mimalloc relanded #79184

Closed
weliveindetail opened this issue Feb 6, 2025 · 1 comment
Closed

Windows arm64 mainline builds fail since mimalloc relanded #79184

weliveindetail opened this issue Feb 6, 2025 · 1 comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. continuous integration Windows Platform: Windows

Comments

@weliveindetail
Copy link
Member

Following up from #79115, mimalloc relanded and x86_64 builds are green. However, the arm64 mainline builds fail to link T:\arm64\mimalloc\bin\mimalloc.dll due to unresolved symbol __popcnt64.

It's referenced from T:\arm64\mimalloc\mimalloc-override-dll\bitmap.obj in function:

?mi_bbitmap_try_find_and_clear_generic@@YA_NPEAUmi_bbitmap_s@@_K1PEA_KP6A_NPEAUmi_bchunk_s@@12@Z@Z

Full link line and error message from https://ci-external.swift.org/job/swift-main-windows-toolchain-arm64/947/:

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.39.33519\bin\HostX86\arm64\link.exe /ERRORREPORT:QUEUE /OUT:"T:\arm64\mimalloc\bin\mimalloc.dll" /NOLOGO "C:\Users\swift-ci\jenkins\workspace\swift-main-windows-toolchain-arm64\mimalloc\ide\vs2022\\..\..\bin\mimalloc-redirect-arm64.lib" kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG:FULL /PDB:"T:\arm64\mimalloc\bin\mimalloc.pdb" /OPT:REF /OPT:ICF /LTCGOUT:"T:\arm64\mimalloc\mimalloc-override-dll\mimalloc.iobj" /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"T:\arm64\mimalloc\bin\mimalloc.lib" /MACHINE:ARM64 /DLL "T:\arm64\mimalloc\mimalloc-override-dll\alloc-aligned.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\alloc-posix.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\alloc.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\arena-meta.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\arena.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\bitmap.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\heap.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\init.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\libc.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\page-map.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\prim.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\options.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\os.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\page.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\random.obj"
         "T:\arm64\mimalloc\mimalloc-override-dll\stats.obj"
            Creating library T:\arm64\mimalloc\bin\mimalloc.lib and object T:\arm64\mimalloc\bin\mimalloc.exp
     1>bitmap.obj : error LNK2019: unresolved external symbol __popcnt64 referenced in function "bool __cdecl mi_bbitmap_try_find_and_clear_generic(struct mi_bbitmap_s *,unsigned __int64,unsigned __int64,unsigned __int64 *,bool (__cdecl*)(struct mi_bchunk_s *,unsigned __int64,unsigned __int64 *))" (?mi_bbitmap_try_find_and_clear_generic@@YA_NPEAUmi_bbitmap_s@@_K1PEA_KP6A_NPEAUmi_bchunk_s@@12@Z@Z) [C:\Users\swift-ci\jenkins\workspace\swift-main-windows-toolchain-arm64\mimalloc\ide\vs2022\mimalloc-override-dll.vcxproj]
     1>T:\arm64\mimalloc\bin\mimalloc.dll : fatal error LNK1120: 1 unresolved externals [C:\Users\swift-ci\jenkins\workspace\swift-main-windows-toolchain-arm64\mimalloc\ide\vs2022\mimalloc-override-dll.vcxproj]
     1>Done Building Project "C:\Users\swift-ci\jenkins\workspace\swift-main-windows-toolchain-arm64\mimalloc\ide\vs2022\mimalloc-override-dll.vcxproj" (default targets) -- FAILED.```
@AnthonyLatsis AnthonyLatsis added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. Windows Platform: Windows continuous integration labels Feb 6, 2025
@weliveindetail
Copy link
Member Author

Fixed with a Visual Studio upgrade from 14.39.33519 to 14.42.34433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. continuous integration Windows Platform: Windows
Projects
None yet
Development

No branches or pull requests

2 participants