diff --git a/README.md b/README.md index 9de810a..ab3663b 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,7 @@ Table of Contents - [Using private Git repositories](#using-private-git-repositories) - [Troubleshooting](#troubleshooting) - [Deploying peer dependencies](#deploying-peer-dependencies) - - [Striping optional dependencies](#striping-optional-dependencies) + - [Stripping optional dependencies](#striping-optional-dependencies) - [Updating the package lock file](#updating-the-package-lock-file) - [Disabling running NPM install](#disabling-running-npm-install) - [API documentation](#api-documentation) @@ -596,8 +596,8 @@ deploy. To generate expressions that install peer dependencies, you can add the $ node2nix --include-peer-dependencies ``` -Striping optional dependencies ------------------------------- +Stripping optional dependencies +------------------------------- When NPM packages with optional dependencies are published to the NPM registry, the optional dependencies become regular runtime dependencies. As a result, when deploying a package with a broken optional dependency, the deployment diff --git a/lib/Package.js b/lib/Package.js index 5d66e14..be8bf30 100644 --- a/lib/Package.js +++ b/lib/Package.js @@ -227,7 +227,7 @@ Package.prototype.resolveDependenciesFromLockedDependencies = function(dependenc if(dependency.bundled) { // Bundled dependencies should not be included callback(); - } else if(self.deploymentConfig.stripOptionalDependencies && dependency.optional) { // When striping optional dependencies feature has been enabled, remove all optional dependencies + } else if(self.deploymentConfig.stripOptionalDependencies && dependency.optional) { // When the stripping optional dependencies feature has been enabled, remove all optional dependencies callback(); } else if(self.production && dependency.dev) { // Development dependencies should not be included in production mode callback(); diff --git a/nix/node-env.nix b/nix/node-env.nix index 4c3174d..57dbf79 100644 --- a/nix/node-env.nix +++ b/nix/node-env.nix @@ -336,7 +336,7 @@ let ++ stdenv.lib.optional (stdenv.isDarwin) libtool ++ buildInputs; - inherit dontStrip; # Striping may fail a build for some package deployments + inherit dontStrip; # Stripping may fail a build for some package deployments inherit dontNpmInstall preRebuild unpackPhase buildPhase; compositionScript = composePackage args; @@ -449,7 +449,7 @@ let ++ stdenv.lib.optional (stdenv.isDarwin) libtool ++ buildInputs; - inherit dontStrip; # Striping may fail a build for some package deployments + inherit dontStrip; # Stripping may fail a build for some package deployments inherit dontNpmInstall unpackPhase buildPhase; includeScript = includeDependencies { inherit dependencies; };