Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash of subtome.com site contents when loading subtome dialog #83

Open
cweiske opened this issue Jul 14, 2015 · 7 comments
Open

Flash of subtome.com site contents when loading subtome dialog #83

cweiske opened this issue Jul 14, 2015 · 7 comments

Comments

@cweiske
Copy link

cweiske commented Jul 14, 2015

When clicking on the "Follow" button on http://cweiske.de/tagebuch/ I see a flash of the subtome.com headings (Logo + "Settings, Subscriptions, Docs") for a short time before the popup is opened.

See http://tmp.cweiske.de/subtome-flash-bug.ogv for a video that shows the issue.

@julien51
Copy link
Member

Hum. Indeed, your video is pretty clear and I can reproduce with http://cweiske.de/tagebuch/ from my Firefox. Now though, when trying on other sites this does not happen.
Is there anything special about your site/integration?

@cweiske
Copy link
Author

cweiske commented Jul 14, 2015

I use a link instead of the recommended tag:

    <a class="follow" href="feed/"
       onclick="(function(btn){var z=document.createElement('script');document.subtomeBtn=btn;z.src='https://www.subtome.com/load.js';document.body.appendChild(z);})(this); return false;">
     Follow
     <img src="images/feed-icon-28x28.png" alt=""/>
    </a>

It loads the following URL:
https://www.subtome.com/?subs/#/subscribe?resource=http:%2F%2Fcweiske.de%2Ftagebuch%2F&feeds=http%253A%252F%252Fcweiske.de%252Ftagebuch%252Ffeed%252F

Which, opened normally in the browser, also exhibits this behavior.

@julien51
Copy link
Member

Christian, I took a couple minutes to look at this, and I'm baffled.
Does this happen with the "regular" button?
I know I'm not being very helpful, but I've got both a 2 year old and a 6 week old at home and it's taking a large toll on my 24 hours :(

@cweiske
Copy link
Author

cweiske commented Jul 27, 2015

I know this problem :)

The same issue happens on http://docs.subtome.com/2015/07/09/subtome-plugin-tt-rss/ when clicking the "Follow" button on the text

Want to learn more about SubToMe in the future? FOLLOW using your favorite feed reader.

@julien51
Copy link
Member

Dang. Not for me:

screencap

What's your OS/browser?

@cweiske
Copy link
Author

cweiske commented Jul 27, 2015

I had the problem in Chromium 43 and Firefox 39 on Ubuntu Linux 14.04.

I hard-reloaded (Ctrl+F5) both my blog as well as your page in both browsers, and now it works without a flaw. Strange.

@cweiske cweiske closed this as completed Jul 27, 2015
@julien51 julien51 reopened this Jul 28, 2015
@julien51
Copy link
Member

Christian, I would not close this right away... because SubToMe has a pretty strong caching mechanism which means the problem can happen the first time during the cache warm-up... and then not happen when you reload.

So, for now, I'll keep the issue open, because it's probably worth investigating further when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants