Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for light shell/terminal themes #62

Open
ninrod opened this issue Feb 17, 2016 · 4 comments
Open

add support for light shell/terminal themes #62

ninrod opened this issue Feb 17, 2016 · 4 comments

Comments

@ninrod
Copy link

ninrod commented Feb 17, 2016

I'm using papercolor (light theme) on iTerm2 and have just installed k. It seems that k doesn't play nice with light themes.

I'm using OSx with coreutils installed so my ls command should behave as in GNU/Linux.

my full shell config can be seen here.
k-on-light-theme

@supercrabtree
Copy link
Owner

Hey, yes I am aware of this, I am currently slowly redoing the color handling, not really sure what to do about this particular problem at the moment. Problem is you only get 256 colors to play with.

As a quickfix to your problem, you could fork this and fiddle with the colors here:

k/k.sh

Lines 170 to 181 in e94410b

SIZELIMITS_TO_COLOR=(
1024 46 # <= 1kb
2048 82 # <= 2kb
3072 118 # <= 3kb
5120 154 # <= 5kb
10240 190 # <= 10kb
20480 226 # <= 20kb
40960 220 # <= 40kb
102400 214 # <= 100kb
262144 208 # <= 0.25mb || 256kb
524288 202 # <= 0.5mb || 512kb
)

@ninrod
Copy link
Author

ninrod commented Feb 17, 2016

Ok, thank you for the gist

@ELLIOTTCABLE
Copy link

@supercrabtree what are your thoughts, here? For simply light-versus-dark, an environment variable is enough, I would think — the behaviour doesn't need to change, just the order (whether “light” or “dark” is considered faded-out and old).

Check out how Vim does it, which is far from perfect, but a start; also see the $COLORFGBG variable (although propagating support for that is problematic in its own way), and in particular, this synthesis of the above into shell-script.

@fawaf
Copy link

fawaf commented Dec 2, 2021

+1 to @ELLIOTTCABLE . even a simple light vs dark initial update would be great. then better color handling can happen afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants