Copy object does not update content type

[ibash]

Bug report

• I confirm this is a bug with Supabase, not with my own application.
• I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Case 1:
Steps:

1. Copy object to a new key with a new content-type
2. Curl the url of the new key
3. Inspect the object in the supabase dashboard

Expected:
content-type header returned from curl are the new content type
mimetype in supabase is updated

Actual:
content-type header returned from curl is the old content type
mimetype in supabase is updated
In this case the content-type and supabase mimetype don't match

Case 2:
Steps:

1. Copy object to the same key, but with the same content-type
2. Curl the url of the key
3. Inspect the object in the supabase dashboard

Expected:
content-type header returned from curl are the new content type
mimetype in supabase is updated

Actual:
Neither the content-type header or the mimetype are updated, they're both the old value

To Reproduce

1. Upload an object to supabase storage with content-type "text/plain"
2. Overwrite the object via the s3 protocol, but specify an alternative content type like "audio/mp4"

import { S3Client, CopyObjectCommand } from "@aws-sdk/client-s3";

const client = new S3Client({
  forcePathStyle: true,
  region: "us-west-1",
  endpoint: "supabase-s3-endpoint",
  credentials: {
    accessKeyId: process.env.ACCESS_KEY_ID,
    secretAccessKey: process.env.SECRET_ACCESS_KEY,
  },
});

const bucket = 'my-bucket'
const key = 'my-key.m4a'

const command = new CopyObjectCommand({
  Bucket: bucket,
  CopySource: `${bucket}/${key}`,
  Key: key,
  ContentType: 'audio/mp4'
});

const data = await client.send(command);

console.log('data is ', data)

Expected behavior

Content-type when curling and mimetype in supabase are both updated.

Additional context

This is a continuation of #580, but creating a new issue so it's not missed since that was marked completed.

[fenos]

Hey @ibash strange, we have a test covering this:
https://github.com/supabase/storage/blob/master/src/test/s3-protocol.test.ts#L969

Will investigate further

[ibash-corpusant]

In the test the key has changed, whereas I'm trying to update the same key. I think also when we ran it against s3 it might not have updated correctly on the s3 side (I can't recall). Thanks!

[fenos]

Created a PR to fix this! @ibash thanks a lot for the report!

[github-actions]

🎉 This issue has been resolved in version 1.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀