Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce binary size #4

Open
1 of 2 tasks
sullyj3 opened this issue Jul 24, 2024 · 1 comment
Open
1 of 2 tasks

Reduce binary size #4

sullyj3 opened this issue Jul 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sullyj3
Copy link
Owner

sullyj3 commented Jul 24, 2024

On hold. We depend on import Lean via socket -> alloy -> lean. I don't think there's much to be done until lean 4's module system improves.

https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Reducing.20executable.20size


Currently 87mb, which is ridiculous. We've eliminated batteries, so I think ever importing Lean or any submodule of Lean is what causes the blowup.

We're using two things from Lean:

  • Lean.HashMap
    We can switch to Std.HashMap when it comes out. In the meantime we can just use an array of pairs, since the data is small.
  • ToJson/FromJson
    Either vendor or replace with our own serialization depending on which is more complicated
@sullyj3 sullyj3 added the enhancement New feature or request label Jul 24, 2024
@sullyj3
Copy link
Owner Author

sullyj3 commented Jul 24, 2024

Blocked on lean, possibly new module system will address this (see roadmap)

@sullyj3 sullyj3 closed this as completed Jul 24, 2024
@sullyj3 sullyj3 reopened this Aug 4, 2024
@sullyj3 sullyj3 changed the title look into reducing binary sizes - finer grained imports? Reduce binary size Aug 4, 2024
@sullyj3 sullyj3 added this to Sand Aug 4, 2024
@sullyj3 sullyj3 moved this to Backlog in Sand Aug 4, 2024
@sullyj3 sullyj3 moved this from Backlog to Ready in Sand Aug 4, 2024
@sullyj3 sullyj3 moved this from Ready to In progress in Sand Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

1 participant