From 087fbb9423bddad611a69f3b5a555cc900b70db5 Mon Sep 17 00:00:00 2001
From: Justin Coyne <jcoyne@justincoyne.com>
Date: Mon, 7 Oct 2024 09:46:11 -0500
Subject: [PATCH] Fix for RSpec/StringAsInstanceDoubleConstant

---
 spec/controllers/renewals_controller_spec.rb | 4 ++--
 spec/controllers/requests_controller_spec.rb | 6 +++---
 spec/features/renew_item_spec.rb             | 2 +-
 spec/features/requests_spec.rb               | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/spec/controllers/renewals_controller_spec.rb b/spec/controllers/renewals_controller_spec.rb
index b4856949..4b1c7ea7 100644
--- a/spec/controllers/renewals_controller_spec.rb
+++ b/spec/controllers/renewals_controller_spec.rb
@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.describe RenewalsController do
-  let(:api_response) { instance_double('Response', status: 201, content_type: :json) }
+  let(:api_response) { instance_double(Faraday::Response, status: 201) }
   let(:mock_client) do
     instance_double(FolioClient, renew_item_by_id: api_response, ping: true)
   end
@@ -42,7 +42,7 @@
     end
 
     context 'when the response is not 201' do
-      let(:api_response) { instance_double('Response', status: 401, content_type: :json) }
+      let(:api_response) { instance_double(Faraday::Response, status: 401) }
 
       it 'does not renew the item and sets flash messages' do
         post :create, params: { item_id: '123' }
diff --git a/spec/controllers/requests_controller_spec.rb b/spec/controllers/requests_controller_spec.rb
index 49b87226..d7e5c3d2 100644
--- a/spec/controllers/requests_controller_spec.rb
+++ b/spec/controllers/requests_controller_spec.rb
@@ -62,7 +62,7 @@
     end
 
     describe '#update' do
-      let(:api_response) { instance_double('Response', status: 204, content_type: :json) }
+      let(:api_response) { instance_double(Faraday::Response, status: 204) }
 
       let(:requests) do
         [instance_double(Folio::Request, key: '123')]
@@ -138,7 +138,7 @@
     end
 
     describe '#destroy' do
-      let(:api_response) { instance_double('Response', status: 204, content_type: :json) }
+      let(:api_response) { instance_double(Faraday::Response, status: 204) }
       let(:mock_client) { instance_double(FolioClient, cancel_request: api_response, ping: true) }
 
       let(:requests) do
@@ -162,7 +162,7 @@
       end
 
       context 'when the response is not 204' do
-        let(:api_response) { instance_double('Response', status: 401, content_type: :json, body: 'foo') }
+        let(:api_response) { instance_double(Faraday::Response, status: 401, body: 'foo') }
 
         it 'does not cancel the hold and sets flash messages' do
           delete :destroy, params: { id: '123' }
diff --git a/spec/features/renew_item_spec.rb b/spec/features/renew_item_spec.rb
index 5d2b9747..ea57d97b 100644
--- a/spec/features/renew_item_spec.rb
+++ b/spec/features/renew_item_spec.rb
@@ -16,7 +16,7 @@
     build(:service_points)
   end
 
-  let(:api_response) { instance_double('Response', status: 201, content_type: :json) }
+  let(:api_response) { instance_double(Faraday::Response, status: 201) }
   let(:bulk_renew_response) do
     { success: [instance_double(Folio::Checkout, key: '1', renewable?: true, item_id: '123', title: 'ABC')] }
   end
diff --git a/spec/features/requests_spec.rb b/spec/features/requests_spec.rb
index 16e2a937..7f03af3b 100644
--- a/spec/features/requests_spec.rb
+++ b/spec/features/requests_spec.rb
@@ -12,7 +12,7 @@
     build(:service_points)
   end
 
-  let(:api_response) { instance_double('Response', status: 204, content_type: :json) }
+  let(:api_response) { instance_double(Faraday::Response, status: 204) }
 
   before do
     allow(FolioClient).to receive(:new).and_return(mock_client)