Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nov. 6 2022 hours incorrect #392

Closed
saseestone opened this issue Sep 27, 2022 · 3 comments
Closed

Nov. 6 2022 hours incorrect #392

saseestone opened this issue Sep 27, 2022 · 3 comments
Assignees

Comments

@saseestone
Copy link

saseestone commented Sep 27, 2022

We need to correct hours for Nov. 6, 2022 for the following libraries:

Earth Sciences; Library & circulation should be: 12p-6pm
East Asia, Library circulation should be: 12p-8p
Engineering, Library & circulation should be: 12p-6p
Lathrop Library, Learning Hub should be: 1p-6p

Currently we're displaying both "closed" and the correct hours range for that location on that date. @cbeer has fixed this issue before on the Sunday when daylight savings ends.

@jcoyne
Copy link
Contributor

jcoyne commented Jan 11, 2023

Is this the same as #40?

@dnoneill dnoneill self-assigned this Mar 13, 2024
@saseestone
Copy link
Author

Niqui and I did some testing on sul-hours-dev. I input hours for Green Library's "Library & circulation" location for Nov 1-4, 2024. The display looks fine. Niqui confirmed the API also looked ok.

We're going to close this ticket (and put a reminder on my calendar to check the hours in October 2024.)

Here' are some screengrabs from this round of testing:

From staff login screen:
image

From https://library-hours-dev.stanford.edu/?week=2024W45
image

@dnoneill
Copy link
Contributor

dnoneill commented Mar 14, 2024

Results from the API:

11-02-2024

[{"id":62976,"day":"2024-11-02","weekday":"Saturday","opens_at":"2024-11-02T08:00:00.000-07:00","closes_at":"2024-11-02T17:00:00.000-07:00","type":"","notes":"","location_slug":"library-circulation","location_id":12,"closed":false}]

11-03-2024

[{"id":62978,"day":"2024-11-03","weekday":"Sunday","opens_at":"2024-11-03T08:00:00.000-08:00","closes_at":"2024-11-03T17:00:00.000-08:00","type":"","notes":"","location_slug":"library-circulation","location_id":12,"closed":false}]

11-04-2024

[{"id":62979,"day":"2024-11-04","weekday":"Monday","opens_at":"2024-11-04T08:00:00.000-08:00","closes_at":"2024-11-04T17:00:00.000-08:00","type":"","notes":"","location_slug":"library-circulation","location_id":12,"closed":false}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants