Make sure we are not generating invalid creation/publication event dates

[lwrubel]

Once sul-dlss/cocina-models#681 is merged, we should be sure we are not creating invalid creation/publication dates that have a date value alongside a structuredValue range.

There were six works (e.g. https://argo.stanford.edu/view/yy114sp3047) that were caught with validation and have description.event.date such as:

         {
                "type": "creation",
                "date": [
                   {
                        "structuredValue": [
                           {
                                "value": "2024-01-03",
                                "type": "start"
                            },
                           {
                                "value": "2024-02-02",
                                "type": "end"
                            }
                        ],
                        "type": "creation",
                        "encoding": {
                            "code": "edtf"
                        }
                    }
                ]
            }

The existing H2 works are being remediated by @arcadiafalcone and @amyehodge (see sul-dlss/argo#4279).

[lwrubel]

It doesn't seem like our current code will generate the invalid value when an interval is used for creation or publication dates.

happy-heron/app/services/cocina_generator/description/date_generator.rb

Line 33 in 3a46d37

def date_props

See also this example, which has a valid creation date: https://argo-qa.stanford.edu/view/yz466fs4308

[lwrubel]

When @amyehodge redeposited the problem items, the cocina was valid, so closing this issue.