Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload image not working (masthead) #2825

Closed
dnoneill opened this issue Jan 27, 2025 · 2 comments
Closed

upload image not working (masthead) #2825

dnoneill opened this issue Jan 27, 2025 · 2 comments
Assignees
Labels
blocker needs to be fixed before we go to -prod with Winter 2020 work spotlight5

Comments

@dnoneill
Copy link
Contributor

dnoneill commented Jan 27, 2025

Also the cropper is super slow to load
https://github.com/user-attachments/assets/19ea98ff-6661-49df-a557-53147c10e9b9

@dnoneill dnoneill added blocker needs to be fixed before we go to -prod with Winter 2020 work spotlight5 labels Jan 27, 2025
@taylor-steve taylor-steve self-assigned this Jan 29, 2025
@taylor-steve
Copy link
Contributor

I can't reproduce this today. I did see it or something similar yesterday. If you get a chance, give it another try. If not, no worries, I'll keep an eye on it.

We've changed a few things, but I have a suspicion that there's a chance there's some asset that isn't getting fully clobbered on stage.

@taylor-steve
Copy link
Contributor

I'm calling this and #2826 a byproduct of pinning the frontend assets in package.json to the repo's main branch which was not always getting clobbers on update. After pinning to specific commit hashes for testing we're getting the exact frontend JavaScript we expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker needs to be fixed before we go to -prod with Winter 2020 work spotlight5
Projects
None yet
Development

No branches or pull requests

2 participants