Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty index values creating empty links (Copyright Renewals) #1763

Open
jvine opened this issue Feb 26, 2020 · 9 comments
Open

Empty index values creating empty links (Copyright Renewals) #1763

jvine opened this issue Feb 26, 2020 · 9 comments

Comments

@jvine
Copy link

jvine commented Feb 26, 2020

Empty facet value at the top of the Author facet:
https://exhibits.stanford.edu/copyrightrenewals

It's possible for a keyboard or SR user to trigger this link:
https://exhibits.stanford.edu/copyrightrenewals/catalog?f%5Bauthor_person_facet%5D%5B%5D=

Empty titles at top of search results -
https://exhibits.stanford.edu/copyrightrenewals/catalog?utf8=%E2%9C%93&exhibit_id=copyrightrenewals&search_field=search&q=

again, keyboard/SR can trigger:
https://exhibits.stanford.edu/copyrightrenewals/catalog/R458196

I'm not sure how this should be fixed - data remediation? If the metadata is accurate (can it be??) then the app needs to handle empty values in a way that makes them perceivable.

These haven't been reported for any other exhibit, so hopefully it's not a broader problem.

Tagging @caaster for attention.

@cbeer
Copy link
Member

cbeer commented Feb 26, 2020

I think these blank values will go away with a reindex.

@mejackreed
Copy link
Contributor

@caaster is it ok if I go ahead and reindex?

@cbeer
Copy link
Member

cbeer commented Mar 3, 2020

Don't bother with copyrightrenewals; I'll be doing something to it for #1759

@corylown
Copy link
Contributor

corylown commented Jul 18, 2024

Need to determine whether this is still an issue.

There are still 13,829 records in the copyrightrenewals exhibit that have an empty string in the author_person_facet. The comments on this issue suggest a re-index might resolve the issue, but it does not appear that the exhibit has been re-indexed. A full re-index may be the first thing to try to resolve this.

Solr query to find these records:

exhibits_prod/query?q=*:*&q.op=OR&indent=true&fl=id,author_person_facet&fq=spotlight_exhibit_slugs_ssim:copyrightrenewals&fq=author_person_facet:""

@caaster
Copy link

caaster commented Jul 23, 2024

@hannahfrost question from Cory: he would like to reindex this exhibit to see if that fixes the problem. Is it ok for him to reindex?

@hannahfrost
Copy link
Member

hannahfrost commented Jul 23, 2024 via email

@corylown
Copy link
Contributor

I am going to need more information about where the records for this collection come from. They have no corresponding resource in the database that I can find and therefore cannot be reindexed.

@dnoneill
Copy link
Contributor

@dnoneill dnoneill assigned dnoneill and unassigned dnoneill Oct 18, 2024
@dnoneill
Copy link
Contributor

Moving back into blocked until we know the status on copyright renewals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants