Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contrast problems in Argo header #4695

Closed
andrewjbtw opened this issue Jan 14, 2025 · 2 comments · Fixed by #4702
Closed

Color contrast problems in Argo header #4695

andrewjbtw opened this issue Jan 14, 2025 · 2 comments · Fixed by #4702
Assignees

Comments

@andrewjbtw
Copy link

Describe the bug
There are a few places in the Argo header that seem to have color contrast issues.

In three cases, the text becomes darker after an interaction, making it hard to distinguish from the background.

  1. Hover over "Argo" text
Screenshot 2025-01-14 at 12 17 25 PM
  1. Expand "Register" dropdown
Screenshot 2025-01-14 at 12 17 48 PM
  1. Expand "Impersonate" dropdown while impersonating (likely the same style issue as for "Register")
Screenshot 2025-01-14 at 12 18 25 PM

User Impact
This might be an accessibility issue? Even if the contrast meets WCAG guidelines, I find it hard to read.

To Reproduce
See screenshots above.

@andrewjbtw andrewjbtw moved this to New Issues (Needs Triage) in Infrastructure Portfolio Production Priorities Jan 14, 2025
@mjgiarlo mjgiarlo self-assigned this Jan 17, 2025
@mjgiarlo mjgiarlo moved this from New Issues (Needs Triage) to In Progress (Not Ordered) in Infrastructure Portfolio Production Priorities Jan 17, 2025
@mjgiarlo mjgiarlo moved this from In Progress (Not Ordered) to Ready (Ordered by Priority) in Infrastructure Portfolio Production Priorities Jan 17, 2025
@mjgiarlo mjgiarlo removed their assignment Jan 17, 2025
@astridu
Copy link

astridu commented Jan 21, 2025

  1. Hover on Argo: text should remain white, and underline should appear
    2 and 3. The text should remain white even when the dropdown is expanded.

@mjgiarlo
Copy link
Member

mjgiarlo commented Jan 21, 2025

@astridu 💬

  1. Hover on Argo: text should remain white, and underline should appear

The component library prevents the underline from appearing due to sul-dlss/component-library#25. Not sure how to proceed. I'll assume we want what's in the component library and leave the hover out of this PR.

2 and 3. The text should remain white even when the dropdown is expanded.

OK, thanks!

mjgiarlo added a commit that referenced this issue Jan 21, 2025
@mjgiarlo mjgiarlo self-assigned this Jan 21, 2025
@mjgiarlo mjgiarlo moved this from Ready (Ordered by Priority) to In Progress (Not Ordered) in Infrastructure Portfolio Production Priorities Jan 21, 2025
mjgiarlo added a commit that referenced this issue Jan 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Not Ordered) to Resolved in Infrastructure Portfolio Production Priorities Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants