Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emailing Selections not working for guest users #3700

Closed
saseestone opened this issue Nov 29, 2023 · 3 comments
Closed

Emailing Selections not working for guest users #3700

saseestone opened this issue Nov 29, 2023 · 3 comments
Assignees
Labels

Comments

@saseestone
Copy link

saseestone commented Nov 29, 2023

We've had a few reports that guest users of SearchWorks (i.e. not logged in) can't currently email selections.

Using an incognito window, I could confirm. Chris/Cory suspect this might be an issue with reCaptcha. The form does have text that refers to reCaptcha, but the reCaptcha check is not displaying:
image

Jira issues from SearchWorks feedback: SW-4255, SW-4254, SW-4251

@saseestone saseestone added the bug label Nov 29, 2023
@saseestone saseestone changed the title Emailing selection option not working for guest users Emailing Selections not working for guest users Nov 29, 2023
@saseestone
Copy link
Author

Confirmed that I can email a selection list if I'm logged in.

@saseestone
Copy link
Author

Cory reported that he can see the recaptcha when using firefox. 😢

I'm using Chrome Version 119.0.6045.199 (Official Build) (arm64)

@taylor-steve taylor-steve self-assigned this Jan 18, 2024
@taylor-steve
Copy link
Contributor

This was last working in SearchWorks v3.20.0. In Blacklight, there was a shift from a "ajax-modal" system to a "blacklight-modal" system. For a time there appeared to be a mismatch between the container and the selector used to do the ajax replace for the modal content. Once this was fixed, the modal content was passed through a slightly different code path that filtered out scripts, breaking recaptcha. Justin patched this for SearchWorks in #3762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants