Skip to content
This repository has been archived by the owner on Feb 23, 2019. It is now read-only.

Output response.error after receiving invalid responses #187

Open
rhoggSugarcrm opened this issue Aug 10, 2017 · 2 comments
Open

Output response.error after receiving invalid responses #187

rhoggSugarcrm opened this issue Aug 10, 2017 · 2 comments
Labels
enhancement

Comments

@rhoggSugarcrm
Copy link
Contributor

rhoggSugarcrm commented Aug 10, 2017 •
edited
Loading

In addition to #139, we also need to output the value of response.error when we receive an invalid response.

response.error.code is particularly interesting, as it sometimes shows up in cases like this.

See https://dareid.github.io/chakram/jsdoc/global.html#ChakramResponse so the API I'm talking about is clear.
@rhoggSugarcrm rhoggSugarcrm self-assigned this Aug 10, 2017
@rhoggSugarcrm
Copy link
Contributor Author

rhoggSugarcrm commented Aug 10, 2017 •
edited
Loading

Also probably useful: including the debugId of the request that failed, so it's easier to match up with the THORN_VERBOSE output.

Not sure if it will work, but it might.

@rhoggSugarcrm
Copy link
Contributor Author

Also keep request/request#2395 in mind. Might even want to submit a PR or issue to Chakram if I can think of one.

@rhoggSugarcrm rhoggSugarcrm removed their assignment Oct 12, 2017
@rhoggSugarcrm rhoggSugarcrm self-assigned this Oct 12, 2017
@rhoggSugarcrm rhoggSugarcrm removed their assignment Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhoggSugarcrm