Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcommands and more #52

Open
daanbreur opened this issue Jan 30, 2021 · 6 comments
Open

Subcommands and more #52

daanbreur opened this issue Jan 30, 2021 · 6 comments

Comments

@daanbreur
Copy link

daanbreur commented Jan 30, 2021

It may be a good idea to add subcommands to the command/commandhandler.
and stuff like AdminOnly / GuildOnly.

the BaseCommand.ts class could be something like this:

export default abstract class BaseCommand {
  constructor(private name: string, private description: string, private category: string, private args: boolean, private guildOnly: boolean, private adminOnly: boolean, private subCommands: [], private aliases: Array<string>) {}

  getName(): string { return this.name; }
  getDescription(): string { return this.description; }
  getCategory(): string { return this.category; }
  getArgs(): boolean { return this.args; }
  getGuildOnly(): boolean { return this.guildOnly; }
  getAdminOnly(): boolean { return this.adminOnly; }
  getSubCommands(): [] { return this.subCommands; }
  getAliases(): Array<string> { return this.aliases; }


  abstract run(client: DiscordClient, message: Message, args: Array<string> | null): Promise<void>;
}

this is just an example and i couldnt get it working. Someone more experianced then me should be able to figure it out quite easily i think.

@loveisglitchy
Copy link

This may be a better idea to put in a pull request rather than an issue.

@daanbreur
Copy link
Author

Well i have no code so i cant make a pr.... and i have no idea on how to implement this.

@loveisglitchy
Copy link

May I ask what you would like the subCommands to do?

@daanbreur
Copy link
Author

Just so you can have all subcommands in seperate files. Like /command subcommand args

@loveisglitchy
Copy link

Isn't that just like aliases?

@SirTenzin
Copy link

No, I think they meant this for example:

/filters clear
/filters 8d off
/filters nightcore on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants