diff --git a/composer.json b/composer.json index fc8a771..478d7c9 100644 --- a/composer.json +++ b/composer.json @@ -17,14 +17,14 @@ }, "require": { "php": ">=5.2", - "composer/installers": "^1.0" + "composer/installers": "^1.0 || ^2.0" }, "require-dev": { - "phpunit/phpunit": ">4.8.20 <6.0", - "squizlabs/php_codesniffer": "3.*", - "wp-coding-standards/wpcs": "^2.2", - "phpcompatibility/phpcompatibility-wp": "^2.1", - "dealerdirect/phpcodesniffer-composer-installer": "^0.7.1" + "phpunit/phpunit": "^9.6.0", + "squizlabs/php_codesniffer": "^3.11.0", + "wp-coding-standards/wpcs": "^3.1.0", + "phpcompatibility/phpcompatibility-wp": "^2.1.0", + "dealerdirect/phpcodesniffer-composer-installer": "^1.0.0" }, "config": { "allow-plugins": { diff --git a/phpcs.xml.dist b/phpcs.xml.dist index 8fff43b..af023e8 100644 --- a/phpcs.xml.dist +++ b/phpcs.xml.dist @@ -18,18 +18,28 @@ - + + + + + + + + + + + + . - */node_modules/* - */tests/* + */node_modules/* + */tests/* */vendor/* - diff --git a/wp-multi-network/includes/classes/class-wp-ms-network-command.php b/wp-multi-network/includes/classes/class-wp-ms-network-command.php index 307e107..9b3b35d 100644 --- a/wp-multi-network/includes/classes/class-wp-ms-network-command.php +++ b/wp-multi-network/includes/classes/class-wp-ms-network-command.php @@ -287,7 +287,7 @@ function ( $file ) { foreach ( $this->fetcher->get_many( $args ) as $plugin ) { $status = $this->get_status( $plugin->file ); if ( $all && in_array( $status, array( 'active', 'active-network' ), true ) ) { - $needing_activation --; + --$needing_activation; continue; } diff --git a/wp-multi-network/includes/classes/class-wp-ms-networks-admin.php b/wp-multi-network/includes/classes/class-wp-ms-networks-admin.php index 5d4d166..eda7361 100644 --- a/wp-multi-network/includes/classes/class-wp-ms-networks-admin.php +++ b/wp-multi-network/includes/classes/class-wp-ms-networks-admin.php @@ -417,7 +417,7 @@ public function page_edit_network() {
-
+
@@ -491,7 +491,7 @@ private function page_all_networks() { -
+ display(); ?>
@@ -541,7 +541,9 @@ private function page_move_site() { array( $site ) ); + // URLs to escape. $add_network_url = $this->admin_url( array( 'page' => 'add-new-network' ) ); + $form_action_url = $this->admin_url( array( 'action' => 'move', 'blog_id' => $site_id ) ); ?>
@@ -559,7 +561,7 @@ private function page_move_site() {
-
+
@@ -618,7 +620,7 @@ private function page_delete_network() {
- +

'; } @@ -914,7 +916,7 @@ private function handle_add_network() { $clone = get_current_site()->id; } - // Sanitize values. + // Unslash posted values. $network_title = ! empty( $_POST['title'] ) ? wp_unslash( $_POST['title'] ) : ''; @@ -928,7 +930,7 @@ private function handle_add_network() { ? wp_unslash( $_POST['new_site'] ) : ''; - // Additional formatting. + // Additional sanitization. $network_title = sanitize_text_field( $network_title ); $network_domain = str_replace( ' ', '', strtolower( sanitize_text_field( $network_domain ) ) ); $network_path = str_replace( ' ', '', strtolower( sanitize_text_field( $network_path ) ) ); @@ -1012,7 +1014,7 @@ private function handle_update_network() { wp_die( esc_html__( 'Invalid network id.', 'wp-multi-network' ) ); } - // Sanitize values. + // Unslash posted values. $network_title = ! empty( $_POST['title'] ) ? wp_unslash( $_POST['title'] ) : ''; @@ -1022,11 +1024,8 @@ private function handle_update_network() { $network_path = ! empty( $_POST['path'] ) ? wp_unslash( $_POST['path'] ) : ''; - $site_name = ! empty( $_POST['new_site'] ) - ? wp_unslash( $_POST['new_site'] ) - : ''; - // Additional formatting. + // Additional sanitization. $network_title = sanitize_text_field( $network_title ); $network_domain = str_replace( ' ', '', strtolower( sanitize_text_field( $network_domain ) ) ); $network_path = str_replace( ' ', '', strtolower( sanitize_text_field( $network_path ) ) ); diff --git a/wp-multi-network/includes/classes/class-wp-ms-networks-capabilities.php b/wp-multi-network/includes/classes/class-wp-ms-networks-capabilities.php index 1a17df4..e52f6c9 100644 --- a/wp-multi-network/includes/classes/class-wp-ms-networks-capabilities.php +++ b/wp-multi-network/includes/classes/class-wp-ms-networks-capabilities.php @@ -36,7 +36,7 @@ public function add_hooks() { * @param array $args Additional context for the capability check. * @return array Filtered required capabilities. */ - public function map_meta_cap( $caps, $cap, $user_id, $args ) { + public function map_meta_cap( $caps, $cap, $user_id, $args ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed // Map our meta capabilities to primitive capabilities first. switch ( $cap ) { diff --git a/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php b/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php index 034030b..57bd053 100644 --- a/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php +++ b/wp-multi-network/includes/classes/class-wp-ms-networks-list-table.php @@ -328,8 +328,8 @@ public function column_title( $network ) { diff --git a/wp-multi-network/includes/functions.php b/wp-multi-network/includes/functions.php index 7ffe86f..f666e8b 100644 --- a/wp-multi-network/includes/functions.php +++ b/wp-multi-network/includes/functions.php @@ -586,8 +586,8 @@ function add_network( $args = array() ) { * @since 2.5.3 */ do_action( 'added_network_blog', $new_blog_id, $new_network_id, $r ); - - // add new blog id as network meta data against the new network + + // add new blog id as network meta data against the new network. $r['network_meta']['main_site'] = $new_blog_id; if ( empty( $r['network_meta']['site_name'] ) ) { diff --git a/wp-multi-network/includes/metaboxes/edit-network.php b/wp-multi-network/includes/metaboxes/edit-network.php index fec1d5a..ac993ab 100644 --- a/wp-multi-network/includes/metaboxes/edit-network.php +++ b/wp-multi-network/includes/metaboxes/edit-network.php @@ -52,7 +52,7 @@ function wpmn_edit_network_details_metabox( $network = null ) { - + - + - +
@@ -79,7 +79,7 @@ function wpmn_edit_network_new_site_metabox() {