Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin post table writes to $_GET #10

Open
joelworsham opened this issue Sep 16, 2016 · 2 comments
Open

Admin post table writes to $_GET #10

joelworsham opened this issue Sep 16, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@joelworsham
Copy link

I added a custom column to sort by a custom meta key. Problem is, $_GET['orderby'] is being written to here: https://github.com/stuttter/wp-event-calendar/blob/master/wp-event-calendar/includes/events/admin.php#L214

I don't believe it's really every appropriate to write to $_GET or $_POST. At least in this case it is making it impossible for me to sort by a custom column.

@JJJ JJJ self-assigned this Sep 19, 2016
@JJJ JJJ modified the milestones: 0.2.2, 0.3.0 Sep 19, 2016
@JJJ JJJ added the bug label Sep 19, 2016
@JJJ
Copy link
Contributor

JJJ commented Sep 19, 2016

Hmm. Yeah; you're probably right. Sorry about that.

I'll check this out and report back when this is addressed.

@joelworsham
Copy link
Author

No worries! Thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants