From 781fdc04d164b8e864f84e2fc55731bad690e848 Mon Sep 17 00:00:00 2001 From: saitjr Date: Wed, 17 Oct 2018 18:13:12 +0800 Subject: [PATCH 1/4] [Bugfix] Add bindir and optimize files in spec --- fabricio.gemspec | 8 +++++--- lib/fabricio/cli/organization.rb | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/fabricio.gemspec b/fabricio.gemspec index 45806ea..14d3e12 100644 --- a/fabricio.gemspec +++ b/fabricio.gemspec @@ -12,10 +12,12 @@ Gem::Specification.new do |spec| spec.summary = "A simple gem that fetches mobile application statistics from Fabric.io API." spec.license = "MIT" - spec.files = `git ls-files -z`.split("\x0").reject do |f| - f.match(%r{^(test|spec|features)/}) - end + # spec.files = `git ls-files -z`.split("\x0").reject do |f| + # f.match(%r{^(test|spec|features)/}) + # end + spec.files = Dir["lib/**/*", "bin/*", "docs/*", "README.md"] + spec.bindir = "bin" spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.require_paths = ["lib"] diff --git a/lib/fabricio/cli/organization.rb b/lib/fabricio/cli/organization.rb index 5b9e9b2..4a25fc9 100644 --- a/lib/fabricio/cli/organization.rb +++ b/lib/fabricio/cli/organization.rb @@ -18,5 +18,7 @@ def all end end + + end end From 2f6d6bbc9405e4e20fbb906fbad9096c5ea815c1 Mon Sep 17 00:00:00 2001 From: saitjr Date: Wed, 17 Oct 2018 18:14:11 +0800 Subject: [PATCH 2/4] [Bugfix] Add bindir and optimize files in spec --- fabricio.gemspec | 3 --- 1 file changed, 3 deletions(-) diff --git a/fabricio.gemspec b/fabricio.gemspec index 14d3e12..4d2c299 100644 --- a/fabricio.gemspec +++ b/fabricio.gemspec @@ -12,9 +12,6 @@ Gem::Specification.new do |spec| spec.summary = "A simple gem that fetches mobile application statistics from Fabric.io API." spec.license = "MIT" - # spec.files = `git ls-files -z`.split("\x0").reject do |f| - # f.match(%r{^(test|spec|features)/}) - # end spec.files = Dir["lib/**/*", "bin/*", "docs/*", "README.md"] spec.bindir = "bin" From aaa3bda3a62a9431d5c71a303c220887acc4683b Mon Sep 17 00:00:00 2001 From: saitjr Date: Wed, 17 Oct 2018 18:20:19 +0800 Subject: [PATCH 3/4] [Bugfix] Fix organization desc from 'get' to 'all' --- lib/fabricio/cli/organization.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fabricio/cli/organization.rb b/lib/fabricio/cli/organization.rb index 4a25fc9..59fa8a5 100644 --- a/lib/fabricio/cli/organization.rb +++ b/lib/fabricio/cli/organization.rb @@ -7,7 +7,7 @@ module Fabricio class Organization < Thor - desc "get", "Get organization" + desc "all", "Get all organization" option :short, :type => :boolean def all organizations = client.organization.all From e74de91a79744f4df589d21c7fc7b7342508c2e1 Mon Sep 17 00:00:00 2001 From: saitjr Date: Wed, 17 Oct 2018 18:22:04 +0800 Subject: [PATCH 4/4] [Optimize] delete some space in organization.rb --- lib/fabricio/cli/organization.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/fabricio/cli/organization.rb b/lib/fabricio/cli/organization.rb index 59fa8a5..7b162d0 100644 --- a/lib/fabricio/cli/organization.rb +++ b/lib/fabricio/cli/organization.rb @@ -17,8 +17,6 @@ def all say(organizations.map { |organization| organization.json }.to_json) end end - - end end