Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control whether to distribute loglines based on the context #235

Open
avibryant opened this issue Oct 16, 2018 · 1 comment
Open

control whether to distribute loglines based on the context #235

avibryant opened this issue Oct 16, 2018 · 1 comment
Milestone
0.3.1

Comments

@avibryant
Copy link
Collaborator

need to thread through an implicit config for this. it should revert to the default when traversing below a unary op.
@avibryant avibryant added this to the 0.3.0 milestone Dec 5, 2019
@avibryant avibryant changed the title allow a great number of max terms when distributing loglines during maybeInline than otherwise control whether to distribute loglines based on the context Dec 7, 2019
@avibryant
Copy link
Collaborator Author

#433 will partially address this. The other thing we should do is analyze whether or not it makes sense to distribute the likelihood during observe when we have a Fn. I believe the heuristic there is, does any non-linear op (like abs) have both Parameter and Placeholder nodes as children; if so, we cannot simplify, but if not, then we can.

@avibryant avibryant modified the milestones: 0.3.0, 0.3.1 Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
1 participant
@avibryant