Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KIP-714 #72

Open
mimaison opened this issue Jan 22, 2025 · 4 comments
Open

Add support for KIP-714 #72

mimaison opened this issue Jan 22, 2025 · 4 comments

Comments

@mimaison
Copy link
Contributor

Since Kafka 3.7.0, with KIP-714 MetricsReporter implementations can also implement the ClientTelemetry interface to gather metrics from Kafka clients.

@scholzj
Copy link
Member

scholzj commented Jan 22, 2025

I guess that should have a wider proposal about how would it work and what would be the benefits.

@mimaison
Copy link
Contributor Author

In order to implement #55 properly, I realized it made more sense to split the reporter into a client and a server module. #55 and this this issue are server only features so having different modules would simplify the reporter logic. My plan is to open a new proposal for that refactoring (this would change class names and dependencies) and it should cover this issue as well.

@scholzj
Copy link
Member

scholzj commented Jan 22, 2025

TBH, I'm not sure how KIP-714 relates to splitting the reporter into a client and server modules. You can split that even without involving anything from KIP-714, or? And even if we would want to support KIP-714, the client part would still need to expose the metrics separately as well because not everyone would want to use KIP-714.

@ppatierno
Copy link
Member

Triaged on 23.1.2025: @mimaison is going to have two proposals for this. One related to the splitting into client and server modules and the other one for supporting KIP-714.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants