assert.Same() for map

[tturbs]

Hello everyone,

I’d like to ask a quick question informally.
118fb83#diff-cfb0727d3ab618e656775b3bb99089481b38a25f8ece2b10913e2d88e492a165R531

I have some concerns regarding this commit. While the changes to the assert.Same() function seem appropriate for pointer comparisons, they are not suitable for comparing maps. In my case, it has become impossible to compare a map with its cloned copy.

If this change is considered appropriate, I believe there should be a separate function specifically for comparing pointer-like objects.

Thanks in advance.

[william-snyders-appfolio]

This is also an issue for me. We have many tests that are verifying cloning of maps, and those tests now fail with this error. This feels like a breaking change.

[william-snyders-appfolio]

After testing things out, it seems like NotSame was not testing what we thought it was. (The below is using the previous version v1.9.0)

func TestSameMap(t *testing.T) {
	a := map[string]string{"z": "z"}
	b := map[string]string{"z": "z"}

  // succeeds
	assert.Equal(t, a, b)

	// Both of these succeed
	assert.NotSame(t, a, a)
	assert.NotSame(t, a, b)

	// Both of these fail
	assert.Same(t, a, a)
	assert.Same(t, a, b)
}

Interestingly, assert.Same(t, a, a) fails with the following error

        	Error:      Not same:
        	           	expected: 0x14000108f30 map[string]string{"z":"z"}
        	           	actual  : 0x14000108f30 map[string]string{"z":"z"}

I would hope this function would work with maps though.