Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Many components forward props to the DOM when they should not #327

Open
kylegach opened this issue Dec 16, 2021 · 0 comments
Open

[Bug] Many components forward props to the DOM when they should not #327

kylegach opened this issue Dec 16, 2021 · 0 comments
Assignees
@kylegach
Labels
bug Something isn't working

Comments

@kylegach
Copy link
Collaborator

Describe the bug

For example, src and type are both rendered on the root div of Avatar: https://5ccbc373887ca40020446347-oghpnhotjv.chromatic.com/?path=/story/avatar--large

Expected behavior

Invalid and unnecessary DOM attributes should not be rendered.

Additional context

Use shouldForwardProp to fix.
@kylegach kylegach added the bug Something isn't working label Dec 16, 2021
@kylegach kylegach self-assigned this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylegach kylegach

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylegach