-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: Ignore unused-parameter warning in the FS plugin #1028
fs: Ignore unused-parameter warning in the FS plugin #1028
Conversation
Jenkins, test this please. |
More errors... 🙄
|
I am a bit less comfortable ignoring the shift-count-overflow warning, but at this point I just want the code to compile everywhere... |
There are some unused parameters in the libext2fs header which together with Wall and Werror means the plugin compilation fails. As a workaround we'll disable the unused-parameter warning for now. Fixes: storaged-project#1026
The warning happens in the libext2fs header.
d0b794b
to
ee5cf5a
Compare
Jenkins, test this please. |
Well you need decide whether to drop |
You could use something along the lines of |
5a9b67f
into
storaged-project:master
Follow-up for storaged-project#1028, we still want to show the warning and not completely supress it.
Follow-up for #1028, we still want to show the warning and not completely supress it.
There are some unused parameters in the libext2fs header which together with Wall and Werror means the plugin compilation fails. As a workaround we'll disable the unused-parameter warning for now.
Fixes: #1026