utils: Check also for aliases in bd_utils_have_kernel_module #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbzatek
reviewed
May 21, 2024
| freelocale (c_locale); | ||
| return FALSE; | ||
| } | ||
|
|
||
| mod = kmod_module_get_module (list); |
There was a problem hiding this comment.
Isn't it better to iterate through the list in case more entries are returned? See https://github.com/lucasdemarchi/kmod/blob/fa67110f896cdef67f42cbc2206ae2a8524acee6/libkmod/README#L53
There was a problem hiding this comment.
And do we really need to check all possible matching modules? Isn't it enough for us that to know that there is at least one module matching the name/alias?
There was a problem hiding this comment.
Yeah, that crossed my mind as well when having dinner yesterday. I guess any first match might be enough in this case.
We want to return true for ext2/3 which are now supported by ext4 module.
vojtechtrefny
force-pushed
the
master_kernel-module-aliases
branch
from
c20c5de to
91c2207
Compare
tbzatek
approved these changes
May 22, 2024
vojtechtrefny
merged commit 7cd19d1
into
storaged-project:master
32 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to return true for ext2/3 which are now supported by ext4 module.