Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Serde and/or Borsh support for TargetAddr #62

Open
void-ripper opened this issue Jan 7, 2025 · 2 comments
Open

Feature: Serde and/or Borsh support for TargetAddr #62

void-ripper opened this issue Jan 7, 2025 · 2 comments

Comments

@void-ripper
Copy link

While not of life threatening importance, man that would be neat.

@RoKu1
Copy link
Contributor

RoKu1 commented Feb 7, 2025

will pick this up

RoKu1 pushed a commit to RoKu1/tokio-socks that referenced this issue Feb 14, 2025
@sticnarf
Copy link
Owner

I'm inclined not to add such supports to TargetAddr.

The main purpose of having this type is to simulate method overloading, so Socks5Stream::connect can handle different types of targets.

I don't expect a TargetAddr to be (de)serialized. If you want to (de)serialize a target, just use a string for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants