Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the gags are not working properlybug report #7

Open
giggle05 opened this issue Jun 15, 2022 · 4 comments
Open

the gags are not working properlybug report #7

giggle05 opened this issue Jun 15, 2022 · 4 comments

Comments

@giggle05
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior for example:

  1. from your control room, type this

Expected behavior
A clear and concise description of what you expected to happen. For example, the woof sound should play followed by the stuns sound, and then a listing of roundtime.

further helpful information

  • OS and version: [e.g. iOS 14]
    What version of the vipmud client are you using? (I.E. 1.0, 2.0)

Additional context
Add any other context about the problem here.
so the spk is being problematic specially when gunning because the gags don't seem to work properly. It still reports when the ship gets hit even with the ship gagging on. That should not happen at all because it is very spammy. also when the ship is tracked, I hope it doesn't say the TTA thing. should just say the directions of the tracked target without saying TTA contact. gmg is also having problem when you are the repair suit because it doesn't make a sound for when you enter the room that has the containers in it. I hope this can be fixed soon. So far that's all the issue I have found. Thank you for taking the time fixing the spk. PS, I am using VIPMUD 2.

@stickbear2015
Copy link
Owner

stickbear2015 commented Jun 15, 2022

Please note failing to follow the template makes things difficult to resolve properly.
I see you put your report at the bottom of the template.
I'll get this assigned to someone or look at it myself as time permits.
Thanks.

@ryanb96
Copy link

ryanb96 commented Oct 30, 2023

I have a fix for this, just running a few other tests and will post a PR, most likely on Tuesday

@ryanb96
Copy link

ryanb96 commented Jan 4, 2025

I have code that fixes this as well as several other thigns. This SP still active if so I will post a pR, if not will fork and make my own... @stickbear2015 can you confirm?

@stickbear2015
Copy link
Owner

@ryanb96 if you enter a PR I can merge it and put out a knew release. Please reference this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants