Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetterSleeping Revived debuffs not triggering #18

Open
Pirogiran opened this issue Jan 14, 2023 · 5 comments
Open

BetterSleeping Revived debuffs not triggering #18

Pirogiran opened this issue Jan 14, 2023 · 5 comments
Assignees
Labels
bug Something isn't working compat Mod compatibility no response from other mod author No response from other mod author about mod compatibility

Comments

@Pirogiran
Copy link

BetterSleeping Revived mod makes it so that when you sleep you get a buff, and if you do not sleep, then debuffs are given.
The buffs don't seem to work after waking up with Realistic Sleep.

@Steveplays28
Copy link
Member

I'll take a look, thanks for the report!

@Steveplays28 Steveplays28 added this to the 1.7.0 milestone Jan 14, 2023
@Steveplays28 Steveplays28 self-assigned this Jan 14, 2023
@Steveplays28 Steveplays28 added bug Something isn't working compat Mod compatibility labels Jan 14, 2023
@Steveplays28
Copy link
Member

Steveplays28 commented Jan 15, 2023

I think I see the issue, I'm just setting sleeping players to 0 to wake them up, though that doesn't register the players' wakeUp events, which BetterSleeping Revived relies on.
I'll call wakeSleepingPlayers() instead, that should fix the issue.

I'll include this fix in the next release, 1.7.0.

@Steveplays28 Steveplays28 changed the title [Compatibility] BetterSleeping Revived BetterSleeping Revived debuffs not triggering Jan 15, 2023
@Steveplays28
Copy link
Member

Steveplays28 commented Jan 15, 2023

I tried to fix this, but I have a suspicion that this is an issue on their part, due to the time not being precisely 24000 when players wake up, which they check for in their code. Not sure though.
I did replace the hacky wake up code with the proper wakeUpSleepingPlayers() function though, so that's already a step in the right direction.

I'll see what I can do, will move this issue to a later version.

@Steveplays28 Steveplays28 removed this from the 1.7.0 milestone Jan 15, 2023
@Pirogiran
Copy link
Author

I think i can open an issue on their github page.

@Steveplays28
Copy link
Member

Steveplays28 commented Jan 16, 2023

Thank you! I added a comment to the issue with some details.
I'll have to do some debugging at some point to figure out exactly where the issue lies, not quite too sure at the moment.

@Steveplays28 Steveplays28 added the no response from other mod author No response from other mod author about mod compatibility label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compat Mod compatibility no response from other mod author No response from other mod author about mod compatibility
Projects
None yet
Development

No branches or pull requests

2 participants