Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone issues with lightbox #284

Open
roykho opened this issue Jul 26, 2013 · 3 comments
Open

Clone issues with lightbox #284

roykho opened this issue Jul 26, 2013 · 3 comments

Comments

@roykho
Copy link

roykho commented Jul 26, 2013

I am finding issues when the slider is in carousel mode and when on the sldie that is a clone, the lightbox that I added per click doesn't work.

If the sldie is not a clone, it works fine. I didn't look at the code for this yet but could it be clone function not delegating the event handlers? So perhaps clone() should be clone( true, true )?

@roykho
Copy link
Author

roykho commented Jul 26, 2013

Ok I have went into the code and changed every occurrence of clone() to clone( true, true ) and now the lightboxes all work. So this confirms that when the element is cloned, it wasn't delegating the events that were previously attached. Using clone( true, true ) will keep the events attached.

@davidd07
Copy link

Thanks! At first glance it seemed quite obvious that bindevents were not being carried across to the cloned slides. Thanks for confirming. I am surprised no one else has had a similar issue.

@divij101
Copy link

divij101 commented Mar 7, 2014

Thank you splashingpixels very much! I was facing the same issue, now it works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants