Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Update Contribution Guide with formatting rules #2035

Closed
1 task done
daverolo opened this issue Sep 4, 2024 · 0 comments · Fixed by #2038
Closed
1 task done

[Enhancement]: Update Contribution Guide with formatting rules #2035

daverolo opened this issue Sep 4, 2024 · 0 comments · Fixed by #2038
Labels
enhancement Request or proposal for a new feature or enhancement

Comments

@daverolo
Copy link
Contributor

daverolo commented Sep 4, 2024

Describe the enhancement

Update Stereum Contribution Guide with the requirements mentioned below.

Quote @daGscheid:
If you want to merge something into Stereum, please use npm run format:check to check the format of your code and run npm run format to format your code, before making a PR.

This will from now and onwards be enforced!
If you have questions about that, please just ask.
Thank you 🙏

Dependencies

No response

Additional Context

No response

Acknowledgment

  • I have reviewed the existing enhancements and confirm that this suggestion is unique.
@daverolo daverolo added the enhancement Request or proposal for a new feature or enhancement label Sep 4, 2024
daGscheid added a commit that referenced this issue Sep 4, 2024
@daGscheid
Update README.md
b3e52fa 
#2035
@daGscheid daGscheid mentioned this issue Sep 4, 2024
Merged
NeoPlays pushed a commit that referenced this issue Sep 4, 2024
@daGscheid
Update README.md (#2038)
b7941c7 
* Update README.md

#2035

* Update README.md

* Update CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request or proposal for a new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md stereum-dev/ethereum-node
1 participant
@daverolo