Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In data_api, URLs for other services are hard-coded to https #15

Open
vsamtuc opened this issue Jan 20, 2025 · 0 comments
Open

In data_api, URLs for other services are hard-coded to https #15

vsamtuc opened this issue Jan 20, 2025 · 0 comments
Assignees
@vsamtuc
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@vsamtuc
Copy link
Contributor

vsamtuc commented Jan 20, 2025

Throughout the codebase, there are several places where the URLs for minio, keycloak and ckan are built over and over. These are currently hard-coded to HTTPS, which is wrong.

There needs to be a major refactoring where these URLs are built correctly throughout the code base. For this purpose, we should create new config entries (e.g., MINIO_PUBLIC_URL vs MINIO_URL) and use these throughout.
@vsamtuc vsamtuc added bug Something isn't working invalid This doesn't seem right labels Jan 20, 2025
@vsamtuc vsamtuc self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsamtuc vsamtuc

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vsamtuc