Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Unmarshal functions #6330

Open
iurimatias opened this issue Feb 5, 2025 · 1 comment
Open

update Unmarshal functions #6330

iurimatias opened this issue Feb 5, 2025 · 1 comment
Assignees
@osmaczko
Labels
core-team
Milestone
2.33.0 Beta

Comments

@iurimatias
Copy link
Member

iurimatias commented Feb 5, 2025 •
edited by osmaczko
Loading

GHSA-q26p-9cq4-7fc2
@iurimatias iurimatias added this to the 2.33.0 Beta milestone Feb 5, 2025
@osmaczko osmaczko moved this to In Progress in Status Desktop/Mobile Board Feb 6, 2025
osmaczko added a commit that referenced this issue Feb 6, 2025
@osmaczko
fix: prevent CVE-2025-24883 in eth-node's crypto package
e377d09 
iterates: #6330
osmaczko added a commit that referenced this issue Feb 6, 2025
@osmaczko
fix: remove go-ethereum's UnmarshalPubkey usage
75f398f 
fixes: #6330
@osmaczko osmaczko mentioned this issue Feb 6, 2025
Open
osmaczko added a commit that referenced this issue Feb 6, 2025
@osmaczko
fix_: prevent CVE-2025-24883 in eth-node's crypto package
a05fa5f 
iterates: #6330
osmaczko added a commit that referenced this issue Feb 6, 2025
@osmaczko
fix_: remove go-ethereum's UnmarshalPubkey usage
5958cf3 
fixes: #6330
osmaczko added a commit that referenced this issue Feb 6, 2025
@osmaczko
fix_: remove go-ethereum's UnmarshalPubkey usage
e803219 
fixes: #6330
osmaczko added a commit that referenced this issue Feb 7, 2025
@osmaczko
fix_: remove go-ethereum's UnmarshalPubkey usage
46ecf1e 
relates: #6330
@osmaczko
Copy link
Contributor

osmaczko commented Feb 7, 2025

It seems that we are not affected by GHSA-q26p-9cq4-7fc2, as we are far behind the go-ethereum upstream, which uses the deprecated elliptic.Unmarshal, which internally performs an IsOnCurve check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osmaczko osmaczko

Labels
core-team
Projects
Status Desktop/Mobile Board
Status: In Progress
Milestone
2.33.0 Beta
Development

No branches or pull requests
2 participants
@iurimatias @osmaczko