Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong weak-subjectivity-checkpoint parsing #2776

Closed
NetherStar64 opened this issue Aug 11, 2021 · 1 comment · Fixed by #3765
Closed

Wrong weak-subjectivity-checkpoint parsing #2776

NetherStar64 opened this issue Aug 11, 2021 · 1 comment · Fixed by #3765
Assignees
@zah
Milestone
v22.6.0

Comments

@NetherStar64
Copy link

NetherStar64 commented Aug 11, 2021 •
edited
Loading

Describe the bug
When using --weak-subjectivity-checkpoint, the argument is parsed wrongly:
blockroot:epoch
the epoch is treated as ":epoch" (so with the colon)

To Reproduce
Steps to reproduce the behavior:

  1. Platform details (OS, architecture): Windows 10
  2. Branch/commit used: stable
  3. Commands being executed: ./run-prater-beacon-node.sh --web3-url=(infura) --weak-subjectivity-checkpoint="0x3c1e98bf132530c669723f58aa3d395be0d0bfaa653152eecb04605
    e203bfeb5:31714"
  4. Relevant log lines:
    Error while processing the weak-subjectivity-checkpoint=0x3c1e98bf132530c669723f58aa3d395be0d0bfaa653152eecb04605e203bfeb5:31714 parameter: invalid unsigned integer: :31714

Maybe related to #2530
@mratsim mratsim self-assigned this Aug 12, 2021
@zah zah added this to the v22.6.0 milestone Jun 9, 2022
@zah zah assigned zah and unassigned mratsim Jun 9, 2022
zah added a commit that referenced this issue Jun 16, 2022
@zah
Correct parsing of the weak-subjectivity-checkpoint parameter; Fixes #…
9a23d3c 
…2776
@zah zah mentioned this issue Jun 16, 2022
Merged
@etan-status etan-status linked a pull request Jun 16, 2022 that will close this issue
Correct parsing of the weak-subjectivity-checkpoint parameter #3765
Merged
@zah
Copy link
Contributor

zah commented Jun 19, 2022

A fix for this has been merged in the unstable branch and will be shipped in Nimbus v22.6.0

@zah zah closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zah zah

Labels
None yet
Projects
None yet
Milestone
v22.6.0
Development

Successfully merging a pull request may close this issue.

Correct parsing of the weak-subjectivity-checkpoint parameter status-im/nimbus-eth2
3 participants
@zah @mratsim @NetherStar64