Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluffy generates invalid BasicRadius payloads #3104

Closed
KolbyML opened this issue Feb 24, 2025 · 1 comment
Closed

Fluffy generates invalid BasicRadius payloads #3104

KolbyML opened this issue Feb 24, 2025 · 1 comment
Labels

Comments

@KolbyML
Copy link

KolbyML commented Feb 24, 2025

2025-02-24T21:31:38.217876Z WARN portalnet::overlay::service::ping: Failed to decode custom payload during process_ping: Failed to decode BasicRadius: InvalidByteLength { len: 34, expected: 32 } protocol=State request.source=enr:-Ii4QPImlmeTTQoUjLz9H7GGoamJkg0DzrRuynlOIk0eQAJLPY34TvaXy5hQVyzYJi9nf5JBxddnluILcgN-ll_jh4KCEyJjZoJpZIJ2NIJpcITCISswiXNlY3AyNTZrMaECcenrPmbBCEhI3aCLAHeFo23FTfhVvnbd44xz4MlVAw6DdWRwgiOM It looks like fluffy is generating invalid basic_radius payloads? Do you guys implement these test vectors https://github.com/ethereum/portal-network-specs/blob/master/ping-payload-extensions/extensions/type-1.md#test-vectors. I need to update the error to print the message received

I am gonna work on a PR to portal-network-specs to expose ping extensions to the json-rpc, so we can add tests in hive for this going into the future

@KolbyML
Copy link
Author

KolbyML commented Feb 25, 2025

fixed in #3106

@KolbyML KolbyML closed this as completed Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants