Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EVM code initialization outside of newComputation #2926

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Move EVM code initialization outside of newComputation #2926

merged 2 commits into from
Dec 11, 2024

Conversation

jangko
Copy link
Contributor

@jangko jangko commented Dec 11, 2024

fix #2883

arnetheduck
arnetheduck reviewed Dec 11, 2024
View reviewed changes
nimbus/transaction/call_common.nim Outdated

var code: CodeBytesRef
if call.isCreate:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let code = if ... is generally nicer in situations like this

@arnetheduck arnetheduck merged commit 674e65f into master Dec 11, 2024
8 checks passed
@arnetheduck arnetheduck deleted the evm-code branch December 11, 2024 13:56
@mjfh mjfh mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnetheduck arnetheduck arnetheduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve EVM code outside of newComputation
2 participants
@jangko @arnetheduck