Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve EVM code outside of newComputation #2883

Closed
jangko opened this issue Nov 28, 2024 · 0 comments · Fixed by #2926
Closed

Resolve EVM code outside of newComputation #2883

jangko opened this issue Nov 28, 2024 · 0 comments · Fixed by #2926
Labels

Comments

@jangko
Copy link
Contributor

jangko commented Nov 28, 2024

From Discord chat:

#2881 reduces seq overhead in EVM - that said, @jangko the design where newComputation sometimes does database lookups feels pretty hairy - can't that be moved somewhere else? it feels like unnecessary maintenance overhead to do the same thing in two places
[20.23]
basically, for precompiles in particular, we don't execution evm opcodes so correspondingly we don't need a stack/memory - the natural way to solve that would be that the code is always resolved "outside" of newComputation and if code is nil, we skip stack/mem allocation instead of that ugly flag..

this also would help with the logic of reducing database lookups for precompiles - the database check is unnecessary (and expensive) - the PR introduces an ugly hack to fix this but ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant