Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Ensure EIP1102 compatibility #78

Open
rachelhamlin opened this issue Oct 29, 2018 · 5 comments
Open

[Draft] Ensure EIP1102 compatibility #78

rachelhamlin opened this issue Oct 29, 2018 · 5 comments
Assignees

Comments

@rachelhamlin
Copy link

Wallet code will no longer be accessible by default after EIP1102 is forced as a breaking change.

User will be required to grant permission for this as well.

@3esmit
Copy link
Member

3esmit commented Nov 6, 2018

When this is going to be implemented in status? How the Dapp can check if the current web3 provider is EIP1102? Perhaps if no account address is provided then it should consider EIP1102?

@rachelhamlin
Copy link
Author

Not until the week of 19/11.

We decided to punt it until OKR voting was finished so as not to break that DApp. Embark team has some further work to do to support it elegantly and the EIP has changed again multiple times as well, as have other teams' roll-out strategies.

@jeluard
Copy link
Contributor

jeluard commented Nov 7, 2018

@3esmit @bgits Most of the work will be abstracted for us by embark.
A DApp should assume EIP1102 is available and be modified accordingly as all browsers are pushing it as default and the old method will be deprecated soon.

@3esmit
Copy link
Member

3esmit commented Nov 21, 2018

What the next step for implementing this?

@rachelhamlin
Copy link
Author

rachelhamlin commented Nov 21, 2018

EIP1102 is now optional for users with browser privacy mode.

There is an Embark update coming in the next ~2 weeks that will allow you to trigger the request based on user action, rather than during app initialization. When that's available, we should integrate EIP1102.

@iurimatias any update on that user story 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants