Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow selection of which rewards to withdraw as denom #56

Open
doofer33 opened this issue Mar 29, 2022 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@doofer33
Copy link

doofer33 commented Mar 29, 2022

So recently we got this new feature to withdraw staking rewards as a denom of choice: 097b8c3

This is a extremely useful feature that many users including myself have been waiting for, but unfortunately its not usable in the current form for people with ledger hardware wallets, as it's trying to swap too many tokens in a single transaction, users will be met with the following error message:

Untitled

From what I have heard by asking around, this seems to be a limitation of the ledger itself, and not really possible to "fix".

Proposed feature(s):
Because of the above issue, can we add a selector on the withdraw rewards page to choose which tokens out of all the rewards, we want to convert into the denom?

Here is a picture to show what I mean, it's just something I drew up in paint to show the rough idea of this proposed solution:
image

I believe this is a fairly straightforward solution that would solve the problem of ledger users encountering the "too many tokens" error, since they can just pick the two or three tokens that are worth something to swap, rather than all 20 something tokens, most of which are in extremely small amounts anyways.

Repository owner deleted a comment Mar 31, 2022
Repository owner deleted a comment Apr 1, 2022
Repository owner deleted a comment Apr 2, 2022
@simcheolhwan
Copy link
Contributor

Your opinion makes sense, but this application will become increasingly complex to handle all cases.
But thank you for your good opinion. I'll look again at how to improve it someday.

@simcheolhwan simcheolhwan added the enhancement New feature or request label Apr 4, 2022
@Kayanski
Copy link

Hey guys, sorry to dig this up but we get this exact same error on Terra Station on Terra 2.0 when trying to send multiple messages at once each of which has some luna sent along with the message. Do you think this error is still possible on Terra 2?0 without stable denoms ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants