Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing session argument in Admin constructor #121

Open
fjbosch opened this issue Oct 25, 2022 · 1 comment
Open

Missing session argument in Admin constructor #121

fjbosch opened this issue Oct 25, 2022 · 1 comment

Comments

@fjbosch
Copy link

fjbosch commented Oct 25, 2022

When initializing an Admin object, it is sometimes desired to include some custom connection. For the stardog.Connection object that is possible by first creating a requests.Session object and providing it to the constructor of stardog.Connection. However, stardog.Admin accepts similar arguments as Connection, but it does not take a requests.Session as an argument.

I think Admin should be consistent with Connection and accept a session as an argument. It is also needed for custom connection requirements for both Admin and Connection instances.

0001-Add-a-request.Session-argument-to-Admin.txt

@scardena
Copy link
Collaborator

you are right, we should add a custom Session object to the admin class too. Please feel free to submit a PR. If you have time, writing a test for it will be highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants