Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): add ft eval create job api #2971

Merged
merged 15 commits into from
Nov 16, 2023
Merged

feat(controller): add ft eval create job api #2971

merged 15 commits into from
Nov 16, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 13, 2023 •
edited
Loading

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (ee53554) 82.96% compared to head (10e83ac) 83.05%.

Files Patch % Lines
...lops/domain/evaluation/storage/EvaluationRepo.java 71.42% 11 Missing and 25 partials ⚠️
.../starwhale/mlops/domain/ft/FineTuneAppService.java 67.64% 10 Missing and 1 partial ⚠️
...ain/java/ai/starwhale/mlops/domain/job/JobDao.java 52.94% 8 Missing ⚠️
...ain/java/ai/starwhale/mlops/api/JobController.java 36.36% 6 Missing and 1 partial ⚠️
...ops/domain/ft/FineTuneEvaluationUpdateWatcher.java 60.00% 5 Missing and 1 partial ⚠️
...ops/domain/evaluation/EvaluationUpdateWatcher.java 69.23% 4 Missing ⚠️
...ava/ai/starwhale/mlops/api/FineTuneController.java 0.00% 3 Missing ⚠️
...i/starwhale/mlops/domain/job/JobServiceForWeb.java 25.00% 3 Missing ⚠️
...tarwhale/mlops/domain/job/cache/HotJobsLoader.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2971      +/-   ##
============================================
+ Coverage     82.96%   83.05%   +0.09%     
- Complexity     3114     3122       +8     
============================================
  Files           557      557              
  Lines         30354    30050     -304     
  Branches       1827     1752      -75     
============================================
- Hits          25183    24958     -225     
+ Misses         4366     4288      -78     
+ Partials        805      804       -1
Flag Coverage Δ
console ?
controller 74.06% <66.38%> (-0.03%) ⬇️
standalone 92.09% <100.00%> (+0.04%) ⬆️
unittests 92.09% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anda-ren
anda-ren approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 0289bd8 into star-whale:main Nov 16, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anda-ren anda-ren anda-ren approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

Assignees
No one assigned
Labels
e2e feature ✨ new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @anda-ren