feat: make selection node mechanism route based #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @KVV94 any update on the failed tests? |
Just fixed the unit tests. They are passing successfully now. |
Rassl
reviewed
Feb 6, 2025
| import { useModal } from '~/stores/useModalStore' | ||
| import { useUserStore } from '~/stores/useUserStore' | ||
| import { NodeExtended } from '~/types' | ||
| import { executeIfProd, getLSat } from '~/utils' | ||
| import { SuccessNotify } from '../common/SuccessToast' | ||
| import { useNodeNavigation } from '../Universe/useNodeNavigation' |
| @@ -7,6 +7,7 @@ import { useDataStore, useNodeTypes } from '~/stores/useDataStore' | |||
| import { useGraphStore, useHoveredNode, useSelectedNode } from '~/stores/useGraphStore' | |||
| import { NodeExtended } from '~/types' | |||
| import { colors } from '~/utils' | |||
| import { useNodeNavigation } from '../../useNodeNavigation' | |||
There was a problem hiding this comment.
should not we add routing for non mindset part too ?
There was a problem hiding this comment.
I've just added the routing for the non mindset part as well. Thank you for noticing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket № 2645
closes #2645
Problem:
Currently, the selected node state is managed through application state, making navigation less predictable and hindering the use of standard browser features (like the Back button). We need to make the node selection mechanism route-based.
Solution:
Implemented a route-based node selection mechanism through a new useSelectedNodeFromUrl hook that synchronizes URL state with the selected node state. This makes node selection more predictable and allows for better browser integration
Changes:
Testing:
useNodeNavigation tests:
useSelectedNodeFromUrl tests:
Notes:
Using replace: true in navigation to prevent unnecessary browser history entries
No state changes occur when node ID from URL is not found
Maintained backward compatibility with existing node selection mechanism
Browser navigation (back/forward) now works seamlessly with node selection