Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test env default should be a controlled latest epoch and latest Clarity version #613

Closed
csgui opened this issue Feb 14, 2025 · 1 comment · Fixed by #614
Closed

Test env default should be a controlled latest epoch and latest Clarity version #613

csgui opened this issue Feb 14, 2025 · 1 comment · Fixed by #614
Labels
code quality Improving the quality of the code, and dev experience testing

Comments

@csgui
Copy link
Collaborator

csgui commented Feb 14, 2025

Test environment default value should consider latest epoch and latest Clarity version.

impl Default for TestEnvironment {
    fn default() -> Self {
        Self::new(StacksEpochId::Epoch25, ClarityVersion::Clarity2)
    }
}
@csgui csgui added code quality Improving the quality of the code, and dev experience testing labels Feb 14, 2025
@csgui csgui mentioned this issue Feb 14, 2025
Merged
@Acaccia
Copy link
Collaborator

Acaccia commented Feb 14, 2025

I disagree with this, see my comment here.

@csgui csgui changed the title Test environment default should be latest epoch and latest Clarity version Test env default should be a controlled latest epoch and latest Clarity version Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improving the quality of the code, and dev experience testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix default test environment stacks-network/clarity-wasm
2 participants
@csgui @Acaccia