Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets discovered provide a link to the main conversation #420

Closed
lukehinds opened this issue Dec 19, 2024 · 0 comments · Fixed by #744
Closed

Secrets discovered provide a link to the main conversation #420

lukehinds opened this issue Dec 19, 2024 · 0 comments · Fixed by #744

Comments

@lukehinds
Copy link
Contributor

When Secrets are discovered, the UI provides a link to the main conversation, with the secrets highlighted in red.

aponcedeleonch added a commit that referenced this issue Jan 23, 2025
Closes: #420

This PR introduces:
- Have full conversations in alerts. Until now we were only showing
the message where the alert came from in `*/alerts`
- Match the `chat_id` in the alert conversation to the ones
returned in `*/messages`
- Fixes a grouping issue in which conversations with secrets were
not grouped correctly because of the `REDACTED<>` text.
aponcedeleonch added a commit that referenced this issue Jan 23, 2025
Closes: #420

This PR introduces:
- Have full conversations in alerts. Until now we were only showing
the message where the alert came from in `*/alerts`
- Match the `chat_id` in the alert conversation to the ones
returned in `*/messages`
- Fixes a grouping issue in which conversations with secrets were
not grouped correctly because of the `REDACTED<>` text.
aponcedeleonch added a commit that referenced this issue Jan 24, 2025
Closes: #420

This PR introduces:
- Have full conversations in alerts. Until now we were only showing
the message where the alert came from in `*/alerts`
- Match the `chat_id` in the alert conversation to the ones
returned in `*/messages`
- Fixes a grouping issue in which conversations with secrets were
not grouped correctly because of the `REDACTED<>` text.
aponcedeleonch added a commit that referenced this issue Jan 24, 2025
Closes: #420

This PR introduces:
- Have full conversations in alerts. Until now we were only showing
the message where the alert came from in `*/alerts`
- Match the `chat_id` in the alert conversation to the ones
returned in `*/messages`
- Fixes a grouping issue in which conversations with secrets were
not grouped correctly because of the `REDACTED<>` text.
aponcedeleonch added a commit that referenced this issue Jan 24, 2025
Closes: #420

This PR introduces:
- Have full conversations in alerts. Until now we were only showing
the message where the alert came from in `*/alerts`
- Match the `chat_id` in the alert conversation to the ones
returned in `*/messages`
- Fixes a grouping issue in which conversations with secrets were
not grouped correctly because of the `REDACTED<>` text.
aponcedeleonch added a commit that referenced this issue Jan 24, 2025
* Properly parse conversations into alerts

Closes: #420

This PR introduces:
- Have full conversations in alerts. Until now we were only showing
the message where the alert came from in `*/alerts`
- Match the `chat_id` in the alert conversation to the ones
returned in `*/messages`
- Fixes a grouping issue in which conversations with secrets were
not grouped correctly because of the `REDACTED<>` text.

* Log exceptions on endpints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants