Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live style update #69

Closed
dy opened this issue May 15, 2016 · 6 comments
Closed

Live style update #69

dy opened this issue May 15, 2016 · 6 comments

Comments

@dy
Copy link

dy commented May 15, 2016

Hi @yoshuawuyts!

I am giving a try to sheetify in gl-spectrum and constantly stumbling on the following issue.

I use budo for developing, and sheetify is enabled as "browserify": {"transform": ["sheetify/transform"]} field in package.json. Styles are connected as follows:

var sf = require('sheetify');
var cssClass = sf('./index.css');

function Spectrum () {
...
    this.container.classList.add(cssClass);
...
}

The problem is that each time when I have to change anything in the index.css, I have to restart budo, which is quite annoying tbh.

Is there any sort of workaround, or it is not the sheetify’s concern at all, but rather budo’s?
I might mistaken, but that is not the same for glslify, it updates consistently without server restart.

Thanks.

@ahdinosaur
Copy link
Member

hmm, that seems like a bug to me, as someone who also likes to write css in external files i'd expect that to work as you describe. we should probably re-open #55? in the meantime, it should work if you write css via template strings.

@mikkoh
Copy link
Contributor

mikkoh commented Jun 1, 2016

@dfcreative I know quite a bit of time has passed but did an error get thrown before budo halted?

@dy
Copy link
Author

dy commented Jun 1, 2016

@mikkoh AFAIK no. I don’t see any errors in budo logs, tbh I don’t know how to halt budo, I always do ctrl+c to stop it.
Btw budo -- -t sheetify/transform neither updates styles. I tried also budo --watch-glob *.css -- -t sheetify/transform, that neither works.

@dy
Copy link
Author

dy commented Jun 29, 2016

That is really unfortunate there is no progress on that. Considering the #78 I think I am going to switch to pure insert-css for now. Prefixing rules as .<prefix>-rule is win in readability, isolation and performance over .<randomId> .rule.

@mikkoh
Copy link
Contributor

mikkoh commented Jul 21, 2016

@dfcreative did your issue get fixed after this PR #73 ? I fixed some stuff that stopped the live updates from budo from dying

@dy
Copy link
Author

dy commented Jul 21, 2016

@mikkoh yeah, it did. Thanks! It can be closed I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants