-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files within folders of templates are URL encoded #229
Comments
Thank you for the kind words! Oh, that's bad! Let me think and find a solution with the team! |
Hey @nerdyman Can you try this command in your workflow and see if now it solves your issue?
|
Hey @Aslemammad I have same issue. I tried to use command above, but it doesn't seem to resolve the issue 😞 Full command:
Edit: I've also tried to use old version |
@Aslemammad That didn't work for me either unfortunately, the file paths are still escaped. I used API_URL=https://pkg.pr.new/ pnpx pkg-pr-new@https://be6db5b4.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@236 publish './lib' --template='./docs/example' I'm not sure if #236 would resolve the issue completely though. It looks like it will escape Edit: Does the existing StackBlitz project need to be deleted for the fix to apply? |
I see, I guess that's because it uses the old backend and not the updated one! Can you folks give me the repo you're trying pkg.pr.new on, so I fork it and try it? And |
I'm testing it on the PR, let's see how it goes! |
Ok, as you can see in the PR (example-2), it is working. Sorry for the confusion. Will ship it soon. |
Hi, I've recently set up the GitHub bot in one of my repos. The package publishing is working but nested files in the folder I'm using for the
--template
arg are being URL encoded, causing the file structure to be flatened.Here's a link to the bot comment and the Stackblitz project it created.
The
/
in the file paths has been escaped so the files don't resolve.P.S. really loving the simplicity of this plugin! It's way nicer than publishing pre-releases to npm.
The text was updated successfully, but these errors were encountered: