-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where reasonable, convert tests to free functions #993
Labels
Milestone
Comments
5 tasks
5 tasks
gadomski
added a commit
that referenced
this issue
Oct 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 16, 2023
* refactor: normalize import style #1259 * refactor(tests): modernize version extension tests - #993 - #948 * feat: add experimental to version ext * feat: version is optional in version extension * refactor: test import naming, ext * feat: catalog extensions * refactor: import style * feat: add history media type * feat: separate BaseVersionExtension * feat: impl migration * doc: fixups * chore: update changelog * fix(tests): mark some extra vcrs * fix: pop_if_none on deprecated
This seems straightforward so I'll make an attempt. 28 files have However, please let me know if there's a body of tests I should leave alone until some other work is done. |
Nope, go to town 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We switched to pytest in #939, which means we don't have to use
unittest.TestCase
anymore; we can switch to free functions. In most cases, converting tests should be as simple as changing:to
While this is a little bike-sheddy, this does have some benefits:
The text was updated successfully, but these errors were encountered: