Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StacIO ABC contains non-abstract methods #506

Open
l0b0 opened this issue Jun 30, 2021 · 0 comments
Open

StacIO ABC contains non-abstract methods #506

l0b0 opened this issue Jun 30, 2021 · 0 comments
Milestone

Comments

@l0b0
Copy link
Contributor

l0b0 commented Jun 30, 2021

The StacIO class is declared as an abstract base class, but only two out of ten methods on it are abstract. That makes for a weird structure, where only some of the methods of an ABC need to be overridden in subclasses. I'm not sure what the right approach is here. Maybe a protocol?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants