Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using black as the formatter #316

Closed
lossyrob opened this issue Apr 28, 2021 · 0 comments · Fixed by #309
Closed

Move to using black as the formatter #316

lossyrob opened this issue Apr 28, 2021 · 0 comments · Fixed by #309

Comments

@lossyrob
Copy link
Member

In #309 I've added type annotations everywhere, which end up with some pretty lengthy lines in things like method signatures. I don't think yapf, the current formatter, is handling these situations well

I've been using black in other projects with similar annotations with a lot of success. I'd like to move to it as the formatter for the project.

I'd prefer to do this as a last change in #309. This will cause the diff to be extensive, but as of right now with all the type annotation additions most of the code has changed anyway.

Let me know if there's any objections on this issue, otherwise I'll proceed with that plan and close out this issue with #309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant