From 5fd5b9452bd27aa6220c5b62b28cb4f5f9c9ec04 Mon Sep 17 00:00:00 2001
From: qualitus-dahme <dahme@qualitus.de>
Date: Wed, 29 Jan 2025 10:23:20 +0100
Subject: [PATCH] 0043656: SCORM-Player is flooding the logs (#8920)

* 42276 - SCORM HTTP context

https://mantis.ilias.de/view.php?id=42276

* Strict types error fixed

_getMaxScoreForUser returns float value or null
https://mantis.ilias.de/view.php?id=43296

* Type error fixed

https://support.iliasnet.de/view.php?id=9387
Type error fixed, returning string only

* Type error fixed

https://support.iliasnet.de/view.php?id=9387
Type error fixed, returning string only

* 0043656: SCORM-Player is flooding the logs

Intercept json_decode returning null, causing log messages.
https://mantis.ilias.de/view.php?id=43656
---
 Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php b/Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php
index 1a82c90ab095..bff113aa5675 100755
--- a/Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php
+++ b/Modules/Scorm2004/classes/class.ilSCORM13PlayerGUI.php
@@ -894,6 +894,8 @@ public function writeSharedData(int $sco_node_id): void
         $ilUser = $DIC->user();
         $g_data = json_decode(file_get_contents('php://input'));
 
+	if ($g_data == null) return;
+	    
         //Step 1: Get the writeable stores for this SCO that already have values
         $query = 'SELECT dm.target_id, sd.store '
                . 'FROM cp_datamap dm '