Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MazeGenerators #131

Open
sraaphorst opened this issue Jul 4, 2018 · 0 comments
Open

Refactor MazeGenerators #131

sraaphorst opened this issue Jul 4, 2018 · 0 comments
Labels
refactor Refactoring of the code

Comments

@sraaphorst
Copy link
Owner

There is no inherent reason why we need width and height to be a property of a MazeGenerator; we can simply pass all parameters into the generate method, and as far as I can tell, there is no good reason to not do so. The only possible concern is that this could possibly have some effect on the observer model, but I don't think it'll matter.

@sraaphorst sraaphorst added the refactor Refactoring of the code label Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of the code
Projects
None yet
Development

No branches or pull requests

1 participant